-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiments with luma232, luma686 and gray tags #33
Comments
Luma686 is a good idea, I've been experimenting with Diff686 which seems strictly worse so Luma686 has been a drop-in replacement. LUMA232 depending on sign sounds neat, how small was the improvement and did you try applying the logic to other luma ops? If you're benchmarking on a laptop you probably need to stop using the mouse and keyboard while it runs. Sounds silly but UI gets priority for responsiveness and a laptop is working with tighter resources so it's very noticeable. Cooling may be an issue. The default resolution of one decimal place also exaggerates variability so you might want to edit qoibench.c to use three decimal places. |
I was indeed doing the benchmark on a laptop powered by battery. The difference between LUMA232 with or without taking in account the sign is not very big and it is a bit slower.
|
3 KB saved on average doesn't sound a lot, but after reaping whatever low hanging fruit we can that 3 KB will look pretty tasty. |
I attached my own idea for a balanced list of tags.
Some things I noticed while experimenting ...
I tried not to overdo it with the amount of tags and tried to get a decent amount of compression.
Grand total for images: 420 kb (attached code) vs 463 kb (qoi)
Grand total for images-lance: 1760 kb (attached code) vs 2109 kb (qoi)
Timings on my computer seem to be very inconsistent for some reason.
Maybe someone else can check if interested.
qoi2.h.txt
The text was updated successfully, but these errors were encountered: