Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect expected response length for 'Set Charge Delay' command #2

Open
sjscymru opened this issue Feb 12, 2019 · 3 comments
Open

Comments

@sjscymru
Copy link

Hi there,

I came across this toolbox today, a colleague gave me a copy of paper published in the Brain Stimulation journal.

I actually work for Magstim and I've noticed an issue with the expected response length to the 'Set Charge Delay' (0x6E) command. This should be 6 and not 4 (line 414 of rapid.m). There is an error in the Magstim documentation, and the 'Set Charge Delay' command actually sends back a response in the same form as 'Get System Status' (0x78). That is, when setting the charge delay the response contains the command ack, instrument status, rapid status and the 2-byte extended instrument status + crc for a total of 6 bytes.

Kind Regards

@nicolasmcnair
Copy link
Collaborator

nicolasmcnair commented Feb 14, 2019 via email

@sjscymru
Copy link
Author

Hi Nick,

I've just had a look and yes, this change was made in V10.0 (which was never released) and thus is also present in V11.0. So V9.0 will return 4 bytes, V11.0 will return the 6 bytes.

The latest revision of protocol document is V5.3 which covers V11.0, but it contains this errata with reference to the number of bytes returned for the setChargeDelay function.

Kind Regards,
Simon

@nicolasmcnair
Copy link
Collaborator

nicolasmcnair commented Feb 21, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants