Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shank IDL to Program ELF #81

Merged
merged 16 commits into from
Jun 15, 2024
Merged

Add Shank IDL to Program ELF #81

merged 16 commits into from
Jun 15, 2024

Conversation

ngundotra
Copy link
Contributor

@ngundotra ngundotra commented Jun 11, 2024

Add the compressed IDL to the program's binary under a section header called .solana.idl.

Adding include_idl!() increases program size by 4K bytes.

  • Before including compressed IDL, asset program size: 244K
  • After including .solana.idl, asset program size: 248K

@ngundotra ngundotra marked this pull request as ready for review June 13, 2024 09:10
@febo
Copy link
Contributor

febo commented Jun 14, 2024

@ngundotra This is super cool!

I think we need to install node + pnpm on the lint_rust step for CI to work. Probably all we need is this block:

- name: Install Node.js
  uses: nifty-oss/actions/install-node-with-pnpm@v1
  with:
     version: ${{ env.NODE_VERSION }}
     cache: ${{ env.CACHE }}
     dependencies: true

on the lint_rust step on main.yml after installing Rust.

https://github.com/nifty-oss/asset/blob/main/.github/workflows/main.yml#L73-L77

@ngundotra
Copy link
Contributor Author

@febo I could use some help fixing the rust client tests :) when you have a moment

@febo
Copy link
Contributor

febo commented Jun 14, 2024

@febo I could use some help fixing the rust client tests :) when you have a moment

Having a look now.

@febo
Copy link
Contributor

febo commented Jun 14, 2024

@ngundotra We need to add the node + pnpm install action to both build and test workflows:

- name: Install Node.js
  uses: nifty-oss/actions/install-node-with-pnpm@v1
  with:
     version: ${{ env.NODE_VERSION }}
     cache: ${{ env.CACHE }}
     dependencies: true

Similarly to what was done for lint.

@febo febo merged commit 97ff65a into nifty-oss:main Jun 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants