Feature - grouping delegate #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds an optional delegate field to a grouping extension. The delegate is authorised to mint new assets into the group. The main use case for this change is a program controlling either a mint (candy machine) or a conversion from another asset type. * Added delegate field to grouping extension * Updated group processor to check grouping delegate if present * Updated create instruction to accept an optional grouping_delegate signer Todo: Build changes into interface program - this isn't rebuilt when running programs:build Also perhaps worth considering not reinitialising the data when the max_size is written as there are likely cases where this may need to be updated post creation.
Closed
febo
reviewed
Apr 10, 2024
febo
reviewed
Apr 10, 2024
febo
reviewed
Apr 10, 2024
febo
reviewed
Apr 10, 2024
febo
reviewed
Apr 10, 2024
febo
reviewed
Apr 10, 2024
febo
reviewed
Apr 10, 2024
febo
reviewed
Apr 10, 2024
febo
reviewed
Apr 10, 2024
febo
requested changes
Apr 10, 2024
|
You can also run |
…authorise changes to the collection is there is a delegate present. * Replicated logic in ungroup processor to ensure delegate can also ungroup assets
|
Thanks for your comments! All addressed pending rebuilding the interface program |
joefitter
changed the title
Amazing! I will rebuild the interface on a separate PR after we merge this one. Can you please run the lint on the JS client as well? |
febo
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional delegate field to a grouping extension. The delegate is authorised to mint new assets into the group.
The main use case for this change is a program controlling either a mint (candy machine) or a conversion from another asset type.
Todo: Build changes into interface program - this isn't rebuilt when running programs:build, so the generation never runs and tests fail
Also perhaps worth considering not reinitialising the data when the max_size is written as there are likely cases where this may need to be updated post creation.