Fix impl for writealloc CPI size limits #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not certain, but my hunch is that we need to add some margin to data_len to account for the AccountMeta we're passing into the instruction. We have 3 of them at 34 bytes ea (Pubkey + 2 bool) = 102 bytes above our limit. edit pretty sure this is the case. check out: https://github.com/solana-labs/solana/blob/15d18a03e5203aec6452605cf6381afca46983fa/programs/bpf_loader/src/syscalls.rs#L2750-L2763 (34 * ix.accounts.len() + ix.data.len() <= 1280)
amilz
changed the title
febo
reviewed
Mar 29, 2024
febo
reviewed
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we need to add some margin to
data_lento account for the AccountMeta we're passing into the instruction. We have 3 of them at 34 bytes ea (Pubkey + 2 bool) = 102 bytes above our limit (which is consistent with my testing).Ref:
Solution add
accounts.len() * 34todata_lenHaving trouble w/ my local client building so i haven't tested it.