Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test ginkgo #25

Merged
merged 6 commits into from
Sep 7, 2023
Merged

Change test ginkgo #25

merged 6 commits into from
Sep 7, 2023

Conversation

heriet
Copy link
Member

@heriet heriet commented Sep 7, 2023

Summary

  • Change table driven tests to ginkgo tests.
  • Test_newNodeMounter is not transferd, because it is private function and I think this test less necessary.

Test

$ make test
ginkgo run --cover -coverprofile=cover.out -covermode=count --junit-report junit-report.xml ./...
Running Suite: Driver Suite - /external/repo/github.com/nifcloud/nifcloud-additional-storage-csi-driver/pkg/driver
==================================================================================================================
Random Seed: 1694082881

Will run 7 of 7 specs
•••••••

Ran 7 of 7 Specs in 0.002 seconds
SUCCESS! -- 7 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
        github.com/nifcloud/nifcloud-additional-storage-csi-driver/pkg/driver   coverage: 2.4% of statements
composite coverage: 2.4% of statements

Ginkgo ran 1 suite in 2.72015999s
Test Suite Passed

@heriet heriet requested a review from aokumasan September 7, 2023 10:36
@aokumasan
Copy link
Member

All tests passed on local.

LGTM 🚀

@aokumasan aokumasan merged commit e9cfc20 into main Sep 7, 2023
@aokumasan aokumasan deleted the change-test-ginkgo branch September 7, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants