Rename values of FailureStoreOptions

nielsbauman · Apr 3, 2024 · feeb3dd · feeb3dd
1 parent 755226d
commit feeb3dd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/...streams/src/javaRestTest/java/org/elasticsearch/datastreams/FailureStoreQueryParamIT.java b/...streams/src/javaRestTest/java/org/elasticsearch/datastreams/FailureStoreQueryParamIT.java
@@ -81,7 +81,7 @@ public void testGetIndexApi() throws IOException {
             assertThat(indices.containsKey(backingIndex), is(true));
         }
         {
-            final Response indicesResponse = client().performRequest(new Request("GET", "/" + DATA_STREAM_NAME + "?failure_store=only"));
+            final Response indicesResponse = client().performRequest(new Request("GET", "/" + DATA_STREAM_NAME + "?failure_store=true"));
             Map<String, Object> indices = entityAsMap(indicesResponse);
             assertThat(indices.size(), is(1));
             assertThat(indices.containsKey(failureStoreIndex), is(true));
@@ -98,7 +98,7 @@ public void testGetIndexStatsApi() throws IOException {
         }
         {
             final Response statsResponse = client().performRequest(
-                new Request("GET", "/" + DATA_STREAM_NAME + "/_stats?failure_store=true")
+                new Request("GET", "/" + DATA_STREAM_NAME + "/_stats?failure_store=include")
             );
             Map<String, Object> indices = (Map<String, Object>) entityAsMap(statsResponse).get("indices");
             assertThat(indices.size(), is(2));
@@ -107,7 +107,7 @@ public void testGetIndexStatsApi() throws IOException {
         }
         {
             final Response statsResponse = client().performRequest(
-                new Request("GET", "/" + DATA_STREAM_NAME + "/_stats?failure_store=only")
+                new Request("GET", "/" + DATA_STREAM_NAME + "/_stats?failure_store=true")
             );
             Map<String, Object> indices = (Map<String, Object>) entityAsMap(statsResponse).get("indices");
             assertThat(indices.size(), is(1));
@@ -124,7 +124,7 @@ public void testGetIndexSettingsApi() throws IOException {
         }
         {
             final Response indicesResponse = client().performRequest(
-                new Request("GET", "/" + DATA_STREAM_NAME + "/_settings?failure_store=true")
+                new Request("GET", "/" + DATA_STREAM_NAME + "/_settings?failure_store=include")
             );
             Map<String, Object> indices = entityAsMap(indicesResponse);
             assertThat(indices.size(), is(2));
@@ -133,7 +133,7 @@ public void testGetIndexSettingsApi() throws IOException {
         }
         {
             final Response indicesResponse = client().performRequest(
-                new Request("GET", "/" + DATA_STREAM_NAME + "/_settings?failure_store=only")
+                new Request("GET", "/" + DATA_STREAM_NAME + "/_settings?failure_store=true")
             );
             Map<String, Object> indices = entityAsMap(indicesResponse);
             assertThat(indices.size(), is(1));
@@ -150,7 +150,7 @@ public void testGetIndexMappingApi() throws IOException {
         }
         {
             final Response indicesResponse = client().performRequest(
-                new Request("GET", "/" + DATA_STREAM_NAME + "/_mapping?failure_store=true")
+                new Request("GET", "/" + DATA_STREAM_NAME + "/_mapping?failure_store=include")
             );
             Map<String, Object> indices = entityAsMap(indicesResponse);
             assertThat(indices.size(), is(2));
@@ -159,7 +159,7 @@ public void testGetIndexMappingApi() throws IOException {
         }
         {
             final Response indicesResponse = client().performRequest(
-                new Request("GET", "/" + DATA_STREAM_NAME + "/_mapping?failure_store=only")
+                new Request("GET", "/" + DATA_STREAM_NAME + "/_mapping?failure_store=true")
             );
             Map<String, Object> indices = entityAsMap(indicesResponse);
             assertThat(indices.size(), is(1));
@@ -183,7 +183,7 @@ public void testPutIndexMappingApi() throws IOException {
             assertAcknowledged(client().performRequest(mappingRequest));
         }
         {
-            final Request mappingRequest = new Request("PUT", "/" + DATA_STREAM_NAME + "/_mapping?failure_store=true");
+            final Request mappingRequest = new Request("PUT", "/" + DATA_STREAM_NAME + "/_mapping?failure_store=include");
             mappingRequest.setJsonEntity("""
                 {
                   "properties": {

diff --git a/server/src/main/java/org/elasticsearch/action/support/IndicesOptions.java b/server/src/main/java/org/elasticsearch/action/support/IndicesOptions.java
@@ -417,9 +417,9 @@ public record FailureStoreOptions(boolean includeRegularIndices, boolean include
             ToXContentFragment {
 
         public static final String FAILURE_STORE = "failure_store";
-        public static final String INCLUDE_ALL = "true";
+        public static final String INCLUDE_ALL = "include";
         public static final String INCLUDE_ONLY_REGULAR_INDICES = "false";
-        public static final String INCLUDE_ONLY_FAILURE_INDICES = "only";
+        public static final String INCLUDE_ONLY_FAILURE_INDICES = "true";
 
         public static final FailureStoreOptions DEFAULT = new FailureStoreOptions(true, false);