Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NFT metadata oracle (CSV -> JSON) #3

Conversation

GeorgeFlerovsky
Copy link

Changes:

  • Apply semantic line breaks to README, to improve the terminal-based editor experience and have better git diffs.
  • Apply the assigned CIP number (86) to all our CIP documents.
  • Replace CSV with JSON arrays in tabular updates.
  • Allow tabular updates in cddl/version_2.cddl. (Now that we use JSON arrays, there's no problem in doing so)
  • Add a section on versions 1 and 2 to README.
  • Formatting fixes.

@GeorgeFlerovsky
Copy link
Author

@nicolasayotte plz review and merge.


; =========================================================================
; CIP-???? actions
; CIP-86 actions

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be 0086 as below
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. People seem content to omit the leading zeroes when e.g. mentioning CIP-25...

@nicolasayotte nicolasayotte merged commit 8cbe052 into nicolasayotte:nft-metadata-oracle Feb 27, 2023
@nicolasayotte
Copy link
Owner

We changed the specs for the tabular updates (back) to JSON with a better formatting pattern and the cddl. This is not only much clearer to do and read, but also easier to parse AND results in smaller tx metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants