Adding epoch cost functionality to both algorithms. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the cost of the k-modes algorithm at each epoch can be accessed through the `epoch_costs_` attribute of a `KModes` object after fitting to some data. These are particularly useful when trying to visualise or analyse the convergence of the k-modes algorithm.
See previous commit.
|
Thanks, @daffidwilde ! This looks good, but could you have a look at the failing tests, please? |
|
@nicodv Sorry about how long it's been now. Everything seems to be fine on my fork but I hadn't seen the incorporation of parallelism (something else I had thought of opening a ticket about). Would you rather I resolved these conflicts locally or are you happy to edit yourself? |
|
Just had a proper look over the new implementation. I'll redo this now. |
|
Sorry for forgetting about this PR. Merged now. Thanks for the contribution, @daffidwilde ! FYI, I've added a simple test case for this too: 8d0e1fc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issue #59, I have added the ability to access the epoch costs in the 'best' iteration of either algorithm. This is done by using the
epoch_costs_attribute of aKModesorKPrototypesobject.I am open to suggestions with regard to my writing style and I hope to hear from you soon.
Cheers