Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: option in TextParser is not used #335

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

cazeaux
Copy link
Contributor

@cazeaux cazeaux commented Oct 8, 2024

Resolves #334

Signed-off-by: Stéphane Cazeaux <[email protected]>
@nicksnyder
Copy link
Owner

Ugh, thanks for finding this. Option in TextParser really should have been a []string, but changing now would be backwards incompatible. There is only one supported option today, so this is moot for now.

I want to avoid pulling in an extra library just for one test so am going to push some changes.

@nicksnyder nicksnyder merged commit 1cb10df into nicksnyder:main Oct 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Option in TextParser is not used
2 participants