Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not encode HTML entities in JSON message files #228

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Conversation

nicksnyder
Copy link
Owner

@nicksnyder nicksnyder commented Sep 29, 2020

There is no reason <, >, or & need to be escaped in message files.

fixes #217

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #228 into main will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   82.60%   82.85%   +0.24%     
==========================================
  Files          14       14              
  Lines        1173     1178       +5     
==========================================
+ Hits          969      976       +7     
+ Misses        142      140       -2     
  Partials       62       62              
Impacted Files Coverage Δ
v2/goi18n/marshal.go 86.11% <100.00%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2aedcf...b5d1898. Read the comment docs.

@nicksnyder nicksnyder merged commit 703c3bd into main Sep 29, 2020
@nicksnyder nicksnyder deleted the htmlentities branch September 29, 2020 04:14
@nicksnyder nicksnyder restored the htmlentities branch September 29, 2020 04:17
mmosta pushed a commit to agilebits/go-i18n that referenced this pull request Nov 30, 2020
@nicksnyder nicksnyder deleted the htmlentities branch December 3, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoiding encoding html characters in json
1 participant