Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes nil reference exception if localization text is empty, fixes #207 #208

Merged
merged 5 commits into from
Sep 28, 2020

Conversation

MJacred
Copy link
Contributor

@MJacred MJacred commented Jan 3, 2020

command will now abort with explanatory error message printing the ID with an empty localization text

fixes #207

@MJacred MJacred changed the title fixes nil reference exception if localization text is empty fixes nil reference exception if localization text is empty, fixes #207 Jan 3, 2020
@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #208 into master will increase coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   82.70%   82.74%   +0.04%     
==========================================
  Files          14       14              
  Lines        1168     1171       +3     
==========================================
+ Hits          966      969       +3     
  Misses        141      141              
  Partials       61       61              
Impacted Files Coverage Δ
v2/goi18n/merge_command.go 71.79% <80.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 354b2fc...0b50ea1. Read the comment docs.

Copy link
Owner

@nicksnyder nicksnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filing an issue and proposing a fix! This diff proposes treating the missing translation as an error but it isn’t obvious to me that it should be. My instinct would be to just skip over the missing one.

v2/goi18n/merge_command.go Outdated Show resolved Hide resolved
v2/goi18n/merge_command.go Outdated Show resolved Hide resolved
v2/goi18n/main.go Outdated Show resolved Hide resolved
@MJacred
Copy link
Contributor Author

MJacred commented Jan 19, 2020

@nicksnyder

Thanks for filing an issue and proposing a fix! This diff proposes treating the missing translation as an error but it isn’t obvious to me that it should be. My instinct would be to just skip over the missing one.

everything is fixed, can you merge the pull request, please?

Copy link
Owner

@nicksnyder nicksnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work here! If you address these two minor comments then I would be happy to merge.

v2/goi18n/merge_command_test.go Show resolved Hide resolved
v2/goi18n/merge_command.go Outdated Show resolved Hide resolved
@nicksnyder nicksnyder merged commit 8f09be8 into nicksnyder:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nil reference exception if localization text is empty
3 participants