-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes nil reference exception if localization text is empty, fixes #207 #208
Conversation
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 82.70% 82.74% +0.04%
==========================================
Files 14 14
Lines 1168 1171 +3
==========================================
+ Hits 966 969 +3
Misses 141 141
Partials 61 61
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for filing an issue and proposing a fix! This diff proposes treating the missing translation as an error but it isn’t obvious to me that it should be. My instinct would be to just skip over the missing one.
everything is fixed, can you merge the pull request, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work here! If you address these two minor comments then I would be happy to merge.
as position of missing text should make no difference
command will now abort with explanatory error message printing the ID with an empty localization text
fixes #207