Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape extracted strings correctly #165

Merged
merged 2 commits into from
May 2, 2019
Merged

escape extracted strings correctly #165

merged 2 commits into from
May 2, 2019

Conversation

nicksnyder
Copy link
Owner

fixes #160

@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #165 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   68.97%   69.01%   +0.03%     
==========================================
  Files          28       28              
  Lines        2350     2353       +3     
==========================================
+ Hits         1621     1624       +3     
  Misses        639      639              
  Partials       90       90
Impacted Files Coverage Δ
v2/goi18n/extract_command.go 64.44% <100%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45eb7b3...9992de0. Read the comment docs.

@nicksnyder nicksnyder merged commit b2843f1 into master May 2, 2019
@nicksnyder nicksnyder deleted the escape branch May 2, 2019 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go18n extract badly handels escapted characters
1 participant