adds ability to define custom funcs in LocalizeConfig #99 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=======================================
Coverage 63.93% 63.93%
=======================================
Files 28 28
Lines 2271 2271
=======================================
Hits 1452 1452
Misses 745 745
Partials 74 74
Continue to review full report at Codecov.
|
nicksnyder
reviewed
Apr 27, 2018
v2/internal/template_test.go
Outdated
| func TestParseWithFunc(t *testing.T) { | ||
| tmpl := &Template{Src: "hello"} | ||
| funcs := template.FuncMap{ | ||
| "foo": func() string { |
There was a problem hiding this comment.
This test doesn't seem to actually use the "foo" func. Can you add a test that does that?
|
forgot to change |
nicksnyder
reviewed
Apr 27, 2018
| tmpl := &Template{Src: "{{foo}}"} | ||
| funcs := template.FuncMap{ | ||
| "foo": func() string { | ||
| return "bar" |
There was a problem hiding this comment.
Can you also check that the value produced by the template is actually “bar”
|
there we go 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to define custom template engine funcs. It adds a
Funcsfield to theLocalizeConfigstruct and passes this parameter togotemplate.Funcs.