prevent nil exception on empty localization text

fixes #207
nicksnyder · Jan 9, 2020 · 71f6d8d · 71f6d8d
1 parent 26334ab
commit 71f6d8d
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/v2/goi18n/merge_command.go b/v2/goi18n/merge_command.go
@@ -125,12 +125,17 @@ func merge(messageFiles map[string][]byte, sourceLanguageTag language.Tag, outdi
 		}
 		templates := map[string]*i18n.MessageTemplate{}
 		for _, m := range mf.Messages {
-			templates[m.ID] = i18n.NewMessageTemplate(m)
+			template := i18n.NewMessageTemplate(m)
+			if template == nil {
+				fmt.Fprintf(os.Stderr, "missing translation for message id %q\n", m.ID)
+				continue
+			}
+			templates[m.ID] = template
 		}
 		if mf.Tag == sourceLanguageTag {
 			for _, template := range templates {
 				if sourceMessageTemplates[template.ID] != nil {
-					return nil, fmt.Errorf("multiple source translations for id %s", template.ID)
+					return nil, fmt.Errorf("multiple source translations for id %q", template.ID)
 				}
 				template.Hash = hash(template)
 				sourceMessageTemplates[template.ID] = template