Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: possibly fix the scrollbar in all charts #1

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

markov00
Copy link

Summary

it's a partial fix for the scrollbar PR.

if you comment out the changes done in tooltip/utils.ts and portal
you can see the current behavior of the "red" portal: we need to "switch" the portal when the portal is overflowing the chart edge. The current behavior instead take into consideration the tooltip width and not the portal width.
Apr-24-2020 13-00-29

This fix add an anchor point to anchor the tooltip at the left or right of the portal depending if we flipped the portal to the right or left of the mouse position

Apr-24-2020 13-02-22

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility, including a check against IE11
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

@nickofthyme
Copy link
Owner

Yup I totally forgot to account for that after it switches. I'll add this to my PR and look at the other issue to noted.

@nickofthyme nickofthyme merged commit 0140bd2 into nickofthyme:fix/tooltip-scroll Apr 24, 2020
@markov00 markov00 deleted the 647-fix branch April 27, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants