Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Down #5

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Merge Down #5

merged 3 commits into from
Jun 4, 2024

Commits on Jun 3, 2024

  1. fix: improve token OIDC logging (#1606)

    ## What kind of change does this PR introduce?
    * Currently, when the "Unacceptable audience in id_token" error is
    returned, it doesn't log the audience claim from the id token, which
    makes it hard to debug. The audience claim from the id token is now
    logged as well when this error is returned.
    * Adds a basic test for the generic id token oidc `getProvider()`
    method, since we currently have 0 coverage for this file
    * The test also uncovered a possible nil pointer panic in the case of
    the generic OIDC provider being returned since in the generic case, the
    `oauthConfig` will be nil. Rather than returning the `oauthConfig`, we
    only need to return the `skipNonceCheck` property since we only check
    for that.
    kangmingtay authored Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5262683 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. feat: make the email client explicity set the format to be HTML (#1149)

    ## What kind of change does this PR introduce?
    This makes the emails to be explicitly set to be HTML formatted instead
    of plain text which helper older clients that cannot figure this out
    themselves.
    
    ## What is the current behavior?
    
    Email messages are sent as plain/text. 
    
    ## What is the new behavior?
    
    Feel free to include screenshots if it includes visual changes.
    
    ## Additional context
    
    Add any other context or screenshots.
    mansueli authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    53e223a View commit details
    Browse the repository at this point in the history
  2. chore: bump alpine and go versions (#1607)

    ## What kind of change does this PR introduce?
    * Bump alpine version to v3.20.0 to resolve an openssl vuln
    * Bump go to v1.22
    kangmingtay authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    e3ebffb View commit details
    Browse the repository at this point in the history