User friendly warning if COVERALLS_REPO_TOKEN is not set #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidkil
changed the title
1 similar comment
|
Since this library doesn't seem to be supported anymore I fix a bunch of things on a fork if you want to check it out and are still pulling the library into your packages: https://github.com/jtwebman/coveralls-next This would be a nice addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when COVERALLS_REPO_TOKEN is not set Coveralls fails with an error message.
Bad response: 422 {"message":"Couldn't find a repository matching this job.","error":true}For a new user it is not clear what the problem is. There is a warning message, but it is only visible if NODE_COVERALLS_DEBUG is enabled. And even then there is so much debugging information that a user will never see it.
I have added a warning message that is displayed when COVERALLS_REPO_TOKEN is not set. I also added the environment variable COVERALLS_QUIETE to run in quiete mode if required.