Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional request and response logging #6

Closed
wants to merge 9 commits into from
Closed

Added optional request and response logging #6

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f230abf
Added request and response logging with a debug field and an optional…
cihantas Oct 14, 2018
6aeff66
Fields shouldn't be exported.
cihantas Oct 14, 2018
0133e40
Remove newlines.
cihantas Oct 14, 2018
29e8936
Additionally use httputil.DumpRequest/Response in debug mode.
cihantas Oct 14, 2018
b2cddbf
Added logging docs.
cihantas Oct 14, 2018
273fe2c
Fix: use non-exported logger field.
cihantas Oct 14, 2018
a1983d9
Remove separate doc file.
cihantas Oct 15, 2018
c51e28b
Add logging documentation to the bottom of the README.
cihantas Oct 15, 2018
1b1904c
Use default logger with stdout and Helix prefix.
cihantas Oct 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func NewClient(options *Options) (*Client, error) {

// Use the default logger, if none was set by the user.
if options.Logger == nil {
c.Logger = &log.Logger{}
c.logger = &log.Logger{}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to set the default output here. If we don't, calling c.logger.Printf will throw an error.

By default I think we should just use stdout. For example:

c.logger = log.New(os.Stdout, "Helix: ", log.LstdFlags)

See the docs for log.New.

}

if options.HTTPClient != nil {
Expand Down