Add support for Webpack 4 #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Webpack 4 all modules added using the `webpack.PrefetchPlugin` also get a reason object explaining why the assets was added. The reason object will have a `type: "prefetch"` property indicating that the `PrefetchPlugin` added it, and potentially more reasons if the asset was also required by other modules. All modules also have a `prefetched` property indicating whether or not it was prefetched, which we could use instead of checking `reasons`. But that would also apply to any dynamically required modules using the `webpackPrefetch` comment hint. Thus to keep the logic as close as possible to how it worked in Webpack 3 this only checks for a Webpack 4 `prefetch` reason object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Webpack 4 all modules added using the
webpack.PrefetchPluginalso get a reason object explaining why the assets was added. The reason object will have atype: "prefetch"property indicating that thePrefetchPluginadded it, and potentially more reasons if the asset was also required by other modules.All modules also have a
prefetchedproperty indicating whether or not it was prefetched, which we could use instead of checkingreasons. But that would also apply to any dynamically required modules using thewebpackPrefetchcomment hint. Thus to keep the logic as close as possible to how it worked in Webpack 3 this only checks for a Webpack 4'sprefetchreason object.