Drop support for Node 6 and 11. #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Sep 20, 2019
There was a problem hiding this comment.
Looking good!
There is still some npm stuff in .travis.yml (just a few lines above the install: change you made but I can't comment on it directly). That needs to become:
script:
- yarn lint:hbs
- yarn lint:js
- yarn testAnd we should remove the $HOME/.npm bit from the caching config in .travis.yml.
In preparation for adding ember-engines for testing lazy routes, this sets node version for CI to 8 and updates node engines to reflect that 8 is the lowest supported version. Also updates to use yarn for installing depdencies. The flags are added to prevent install failures related to having "link" dependencies in package.json. I referred to ember-engines repo for these changes. https://github.com/ember-engines/ember-engines/blob/v0.8.2/package.json#L43 https://github.com/ember-engines/ember-engines/blob/v0.8.2/.travis.yml#L54 Related PR: https://github.com/nickiaconis/ember-prefetch/pull/150jk
jackson-dean
force-pushed
the
update-node-engines
branch
from
83e77aa to
7a6e9f8
Compare
|
Thanks for the review! Addressed all feedback |
rwjblue
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for adding ember-engines for testing lazy
routes, this sets node version for CI to 8 and updates
node engines to reflect that 8 is the lowest supported
version. Also updates to use yarn for installing depdencies.
The flags are added to prevent install failures related to
having "link" dependencies in package.json. I referred to
ember-engines repo for these changes.
https://github.com/ember-engines/ember-engines/blob/v0.8.2/package.json#L43
https://github.com/ember-engines/ember-engines/blob/v0.8.2/.travis.yml#L54
Related PR: #150