Resolve panic from api search #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
nick42d
added a commit
that referenced
this pull request
Sep 4, 2024
* Implement skeletons * Implementation in progres * fix: Resolve panic from api search / improve panic handling (#161) * Implement skeletons * Implementation in progres * Continue implementing Query * Complete Query implementations, complete test inputs * Add types to parse into * Work on getchannelquery * Complete GetChannel parser * Tests pass - GetChannelQuery * Continue parsing implementations * build(deps): bump quinn-proto in the cargo group across 1 directory (#166) * Continue parsing implementation - 1 to go * Complete implementation * Clippy lints * Better bikeshed names * fix: Handle case where top search result is a 'radio' playlist with only 1 subtitle. (#163) * Add new tests for radio/genre search case * Complete patch * Add doctests, specialise id for episodes * Implement skeletons * Implementation in progres * Continue implementing Query * Complete Query implementations, complete test inputs * Add types to parse into * Work on getchannelquery * Complete GetChannel parser * Tests pass - GetChannelQuery * Continue parsing implementations * Continue parsing implementation - 1 to go * Complete implementation * Clippy lints * Better bikeshed names * Add doctests, specialise id for episodes * Rebase on main to fix test BREAKING CHANGE: ChannelID is renamed to ArtistChannelID - allows for new PodcastChannelID also. In additional, video_id field replaced with episode_id field on SearchResultVideo::VideoEpisode, PlaylistEpisode, SearchResultEpisode, HistoryItemEpisode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #160