Choose 'Highest' audio quality by default #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Merged
nick42d
added a commit
that referenced
this pull request
Aug 19, 2024
* Refactor common module * fix: Make the channel/artist thumbnail on playlists/albums optional (#147) * fix: Choose 'Highest' audio quality by default (#150) - resolves #143 * Increase audio quality - possibly resolves crackling * Choose HighestAudio quality by default * Complete marking public structs non exhaustive and implementing derives. Also, fixed two integration test issues; search videos failing due to a non-available song, and a flake issue on add/remove history * Rename some awkward public structs, fix doctests * Refactor common module * Complete marking public structs non exhaustive and implementing derives. Also, fixed two integration test issues; search videos failing due to a non-available song, and a flake issue on add/remove history * Rename some awkward public structs, fix doctests * Fix failing test; renamed struct BREAKING CHANGE: This is a significant breaking change, primarily due to marking many structs non_exhaustive. This breakage now will save breakage in the future. In addition, significant refactoring between modules was undertaken to better organise the project. Further to this, a small number of structs were renamed to better indicate their purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143