-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noise during playback #143
Comments
Hi there, going to be a tricky one. It's possible this is RustAudio/rodio#584. Could you please list a particular song that this was noticeable on? |
Experimenting here with picking a higher quality audio stream, you're welcome to give it a go: https://github.com/nick42d/youtui/tree/iss143-test-audio-quality |
That fixes it. |
Nice one. There was a reason I initially selected low quality audio - high quality audio often caused |
Out of curiosity, do you know what the |
Not off the top of my head I'm afraid, although I believe some digging around and running queries with rusty_ytdl could uncover this. https://docs.rs/rusty_ytdl/latest/rusty_ytdl/enum.VideoQuality.html |
This seems to be safe to implement, PR #150 will be merged if it passes CI. Note it will increase download time a little, so this would be a good future target for configuration. |
* Refactor common module * fix: Make the channel/artist thumbnail on playlists/albums optional (#147) * fix: Choose 'Highest' audio quality by default (#150) - resolves #143 * Increase audio quality - possibly resolves crackling * Choose HighestAudio quality by default * Complete marking public structs non exhaustive and implementing derives. Also, fixed two integration test issues; search videos failing due to a non-available song, and a flake issue on add/remove history * Rename some awkward public structs, fix doctests * Refactor common module * Complete marking public structs non exhaustive and implementing derives. Also, fixed two integration test issues; search videos failing due to a non-available song, and a flake issue on add/remove history * Rename some awkward public structs, fix doctests * Fix failing test; renamed struct BREAKING CHANGE: This is a significant breaking change, primarily due to marking many structs non_exhaustive. This breakage now will save breakage in the future. In addition, significant refactoring between modules was undertaken to better organise the project. Further to this, a small number of structs were renamed to better indicate their purpose.
Really unsure about the possible cause, but playback with youtui has a faint crackling noise present in higher frequencies. I only noticed when I listened to classical music on headphones. I compared the same tracks with youtui and the YT Music web UI (various browsers), and it's only there with youtui.
I've no idea where in the chain of Rodio, cpal, Symphonia (or even elsewhere) the problem may be. Happy to test if you tell me what :)
I'm on Linux, so I expect the output is through ALSA to Pipewire.
The text was updated successfully, but these errors were encountered: