Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work page #29

Merged
merged 14 commits into from
Feb 19, 2024
Merged

Work page #29

merged 14 commits into from
Feb 19, 2024

Conversation

nicholeuf
Copy link
Owner

Resolves #3

@nicholeuf nicholeuf added this to the Portfolio Website V1 milestone Feb 19, 2024
@nicholeuf nicholeuf self-assigned this Feb 19, 2024
Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zen-site-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 10:25pm

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c4490e1) 89.88% compared to head (4feea6e) 93.44%.

Files Patch % Lines
src/app/about/page.tsx 0.00% 1 Missing ⚠️
src/app/contact/page.tsx 0.00% 1 Missing ⚠️
src/app/work/WorkTabs.tsx 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   89.88%   93.44%   +3.56%     
==========================================
  Files          25       31       +6     
  Lines         178      229      +51     
  Branches       15       19       +4     
==========================================
+ Hits          160      214      +54     
+ Misses         18       15       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

To be completed in #30
const [value, setValue] = useState(0);

const handleChange: TabsOnChange = (_, newValue) => {
setValue(newValue);
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test will be completed in separate task #30

@nicholeuf nicholeuf marked this pull request as ready for review February 19, 2024 22:30
@nicholeuf nicholeuf merged commit 0541ff8 into main Feb 19, 2024
7 checks passed
@nicholeuf nicholeuf deleted the work-page branch February 19, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Work Experience Page
1 participant