TypeError bug #92
Merged
TypeError bug #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -169,7 +169,13 @@ def frame2string(frame): | |||
| filename = co.co_filename | |||
| name = co.co_name | |||
| s = '\tFile "{0}", line {1}, in {2}'.format(filename, lineno, name) | |||
| line = linecache.getline(filename, lineno, frame.f_globals).lstrip() | |||
| try: | |||
| line = linecache.getline(filename, lineno, frame.f_globals).lstrip() | |||
There was a problem hiding this comment.
I would assume this is due to lineno == None which can be tested before the call of the function.
There was a problem hiding this comment.
I think so; but there was one other component that I was not very sure of. Therefore I thought try-catch would be a better patch here.
|
Thanks! |
|
I left a little comment and if you or someone else likes, they can submit a different fix. |
|
Thanks, this included in v2.0.7! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick fix to TypeError bug mentioned in #90 . It is a simple try-catch mechanism but the real issue might be deeper.