Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI][tracevalidate] default value for allow-fix #35

Closed
dglaeser opened this issue Apr 25, 2023 · 2 comments
Closed

[CLI][tracevalidate] default value for allow-fix #35

dglaeser opened this issue Apr 25, 2023 · 2 comments

Comments

@dglaeser
Copy link
Contributor

fractopo tracevalidate --help shows for the allow-fix option

--allow-fix,--fix                                             Allow the direct modification of trace file to fix errors. [default: True]

Does this really modify the file (i.e. resaving it to disk)? If so, I am unsure if True should be the default. Modification of the input file should be explicitly requested I would say. Or does this rather mean that the errors are fixed and then the fixed version of the traces are saved into output? if the latter is the case, maybe the docstring for this CLI parameter could be adjusted a bit?
@dglaeser dglaeser mentioned this issue Apr 25, 2023
Closed
nialov added a commit that referenced this issue Apr 26, 2023
@nialov
refactor(cli): adjust cli help for allow_fix
ee6fb40 
It is now mentioned that the input file is not modified unless
explicitly set as the output even with the --allow-fix flag
as suggested in #35.
@nialov nialov mentioned this issue Apr 26, 2023
Merged
@dglaeser
Copy link
Contributor Author

#41 looks good to me, thanks a lot!

@nialov
Copy link
Owner

nialov commented Apr 27, 2023

Thanks a lot for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nialov @dglaeser