Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI][tracevalidate] save validation results into a sub-dir of pwd? #34

Closed
dglaeser opened this issue Apr 25, 2023 · 0 comments · Fixed by #41
Closed

[CLI][tracevalidate] save validation results into a sub-dir of pwd? #34

dglaeser opened this issue Apr 25, 2023 · 0 comments · Fixed by #41

Comments

@dglaeser
Copy link
Contributor

dglaeser commented Apr 25, 2023 •
edited
Loading

As far as I see it, when invoking fractopo tracevalidate PATH_TO_TRACES PATH_TO_AREA, the default is that the validated data is saved in a sub-directory of the input data (e.g. PATH_TO_TRACES)?

That may be intentional, but I was wondering if it is more intuitive to put that data into sub-directories of the current working dir per default?
@dglaeser dglaeser mentioned this issue Apr 25, 2023
Closed
nialov added a commit that referenced this issue Apr 26, 2023
@nialov
refactor(cli): save validated to local directory
62b0eb6 
As suggested in #34, the validated trace data is now saved to a
directory relative to the current directory if the output is not
explicitly set.
@nialov nialov mentioned this issue Apr 26, 2023
Merged
@nialov nialov linked a pull request Apr 26, 2023 that will close this issue
Implement cli suggestions from #34, #35 and #36 #41
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement cli suggestions from #34, #35 and #36 nialov/fractopo
1 participant
@dglaeser