Update to Angular 18 #2508
Open
Update to Angular 18 #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-akinc
force-pushed
the
users/makinc/angular18
branch
from
777d32b to
ca01536
Compare
m-akinc
requested review from
rajsite,
atmgrifter00 and
jattasNI
as code owners
jattasNI
reviewed
Jan 17, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Reminder to update the Angular version mentioned in the nimble-angular README.
|
|
||
| import {BuiltInControlValueAccessor} from './control_value_accessor'; | ||
| // import {RuntimeErrorCode} from '../errors'; |
There was a problem hiding this comment.
Looks like there are a handful of commented out chunks in the forked code. Did you make those changes or is that what it looks like upstream? If you made changes, could you consider summarizing them in the PR description? It's useful context, even if the changes are fairly innocuous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Part of Angular 18 migration (AzDO work item)
👩💻 Implementation
angular-workspace/nimble-angular/src/thirdpartyTEMPORARY (will be reverted before submission):
ni-eslint-config-angulartgz.gitignoreto see .tgz file changes🧪 Testing
Builds and automated tests pass
✅ Checklist