Elapsed time column hld #1579
Merged
Elapsed time column hld #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-akinc
approved these changes
Sep 29, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
…table-column-elapsed-time-hld.md Co-authored-by: m-akinc <[email protected]>
…into elapsed-time-column-hld
atmgrifter00
requested review from
rajsite,
jattasNI and
mollykreis
as code owners
mollykreis
reviewed
Oct 3, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
jattasNI
reviewed
Oct 3, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
jattasNI
reviewed
Oct 3, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Outdated
Show resolved
Hide resolved
jattasNI
reviewed
Oct 3, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-elapsed-time-hld.md
Outdated
Show resolved
Hide resolved
mollykreis
reviewed
Oct 4, 2023
change/@ni-nimble-components-292ee238-87d4-40bc-b76c-941992c1f31e.json
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Outdated
Show resolved
Hide resolved
…31e.json Co-authored-by: mollykreis <[email protected]>
…table-column-duration-text-hld.md Co-authored-by: mollykreis <[email protected]>
…into elapsed-time-column-hld
rajsite
reviewed
Oct 6, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Oct 10, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Show resolved
Hide resolved
jattasNI
approved these changes
Oct 10, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Show resolved
Hide resolved
…into elapsed-time-column-hld
mollykreis
reviewed
Oct 12, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-duration-text-hld.md
Show resolved
Hide resolved
|
|
||
| #### Really large numbers | ||
|
|
||
| At some point numbers that can be formatted as a duration become too large to be practically represented in such a way. We will have a cutoff value (in days) where when the value exceeds that limit, we will revert to displaying the duration as a scientific representation of the value in the seconds unit. |
There was a problem hiding this comment.
I'm curious how you landed on scientific representation of seconds. If it's really large, does someone really want to figure out how long a value like 3.264E61 sec actually represents.
There was a problem hiding this comment.
For very large numbers it seemed more intuitive than saying 3.264E61 days, 59 minutes, 59 sec, etc
Curious about the concern since I just recommended the same thing to @m-akinc for very large and very small numbers best-unit / human-readable units we don't have localized prefixes for.
There was a problem hiding this comment.
I don't have a strong opinion here, but I'll leave it as is until I can be swayed in the other direction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
#1569
AzDO Work Item: SLE elapsed time table column