Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FAST Deps Jan 2022 #339

Closed
mollykreis opened this issue Feb 8, 2022 · 0 comments · Fixed by #348
Closed

Update FAST Deps Jan 2022 #339

mollykreis opened this issue Feb 8, 2022 · 0 comments · Fixed by #348
Assignees
@rajsite

Comments

@mollykreis
Copy link
Contributor

As part of updating FAST, we should also enable the disabled toggle-button test for Enter key interactions -- see #336 (comment)
@mollykreis mollykreis mentioned this issue Feb 8, 2022
Merged
1 task
@rajsite rajsite mentioned this issue Feb 10, 2022
Merged
1 task
rajsite added a commit that referenced this issue Feb 11, 2022
@rajsite
Update Fast Dependencies (#348)
1d07dda 
# Pull Request

## 🤨 Rationale

Updates FAST dependencies to the latest version we can. Unfortunately [hit an issue with select controls](microsoft/fast#5586) that manifests in the [storybook matrix tests](https://60e89457a987cf003efc0a5b-uxxekwhpfi.chromatic.com/?path=/story/tests-select--select-opened-theme-matrix) in an example branch (see console).

Fixes #339 

## 👩‍💻 Implementation

- Updated FAST packages to latest except fast-foundation which is updated to the latest version without the select issue
- Modified fast-foundation range specifier to avoid package with error

## 🧪 Testing

Rely on existing tests and CI.

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajsite rajsite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Fast Dependencies ni/nimble
2 participants
@rajsite @mollykreis