Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled rich text editor tests on Firefox #2404

Open
aagash-ni opened this issue Sep 19, 2024 · 1 comment
Open

Disabled rich text editor tests on Firefox #2404

aagash-ni opened this issue Sep 19, 2024 · 1 comment
Assignees

Comments

@aagash-ni
Copy link
Contributor

aagash-ni commented Sep 19, 2024

🧹 Tech Debt

The following tests are failing intermittently in Firefox but can't be consistently replicated locally or in the pipeline:

  • should display the mention popup for multiple mention configuration elements
  • Mention node

After further look, I managed to replicate the error ( mentioned below ) in Firefox just once over four days of testing, and only in the local environment. I'm still trying to determine the exact steps to reproduce the issue.

InvalidStateError: Selection.collapseToEnd: No selection range exists thrown 

Discussion reference: Bug 2787273: Intermittent failures in Rich Text Editor for Mention support

@aagash-ni aagash-ni added tech debt triage New issue that needs to be reviewed labels Sep 19, 2024
@jattasNI
Copy link
Contributor

@aagash-ni could you edit the description of this issue to include the error message that the tests fail with? That will help with searchability, bucketing other tests into the same issue, and knowing when this has been fixed.

@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Oct 1, 2024
@m-akinc m-akinc assigned m-akinc and aagash-ni and unassigned m-akinc Oct 1, 2024
rajsite pushed a commit that referenced this issue Oct 14, 2024
# Pull Request

## 🤨 Rationale

**Issue**: [#2219](#2219)

We are re-enabling tests that were previously disabled due to
intermittent failures and disabling only in the Firefox environment, as
the issue occurred only once during four days of testing. Additionally,
there were other cases that are validating the same mention workflow,
which has been successfully running in Firefox.

After conducting tests in a loop environment on GitHub agents, the tests
did not fail with the same error.

Please refer to the bug discussion for all the pipeline checks: [Bug
2787273](https://dev.azure.com/ni/DevCentral/_workitems/edit/2787273) -
Intermittent failures in the Rich Text Editor for Mention support.

Following this, we will monitor for any related failures and have
created a [TD](#2404) to track the
skipped Firefox browser tests.

## 👩‍💻 Implementation

Re-enabled the disabled test case.

Update:
1. For test `should show mention popup for multiple mention
configuration elements`:
1. Instead of committing the `@` mention node, remove the `@` and add
`!` to verify other mention type list options and popup visibility.
2. The test can now verify the list options for multiple mentions by
opening the popup.
1. For test `Serialize rich text editor content to its respective
markdown Mention node`:
1. Update the `clickMentionListboxOption` to focus on the editor before
committing the mention from the list options.
1. Update other methods that modify the content of the editor to also
receive focus to the editor to ensure any other intermittencies.
1. Update the `isMentionListboxOpened` method to read from the `hidden`
property and also wait before reading to resolve the intermittent
failures on Firefox when running in loop.

See the discussion below for more details,
#2403 (comment)

## 🧪 Testing

NA

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Vivin Krishna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants