Add CfgTimeStartTrig to daqmx-python #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeborahOoi96
requested review from
zhindes,
maxxboehme and
bkeryan
as code owners
bkeryan
requested changes
Jan 24, 2024
src/codegen/templates/library_interpreter/default_c_function_call.py.mako
Outdated
Show resolved
Hide resolved
src/codegen/templates/grpc_interpreter/default_grpc_function_call.py.mako
Outdated
Show resolved
Hide resolved
zhindes
requested changes
Jan 24, 2024
bkeryan
requested changes
Jan 26, 2024
src/codegen/templates/library_interpreter/default_c_function_call.py.mako
Outdated
Show resolved
Hide resolved
src/codegen/templates/library_interpreter/default_c_function_call.py.mako
Outdated
Show resolved
Hide resolved
zhindes
approved these changes
Jan 26, 2024
bkeryan
reviewed
Jan 26, 2024
bkeryan
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR adds Time Trigger API support for the following functions in nidaqmx-python:
DAQmxCfgTimeStartTrig, taking into consideration the AbsoluteTime comments brought up in Charity's draft PR
Why should this Pull Request be merged?
It provide support for CfgTimeStartTrig in python.
What testing has been done?
Ran nidaqmx-python code generator and validated the API was generated correctly
All existing functional test passed.
To keep PRs small I will add trigger functional test coverage in a follow-up PR.