codegen: Use python_codegen_method value, not its presence #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Keryan <[email protected]>
bkeryan
force-pushed
the
users/bkeryan/override-python-codegen-method
branch
from
55935a6 to
5318c23
Compare
1 task
zhindes
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
functions_addon.pycan't override'python_codegen_method': 'no'because we are testing its presence instead of its value. Test its value so thatfunctions_addon.pycan enable codegen by setting'python_codegen_method': None.Why should this Pull Request be merged?
Enable overriding
'python_codegen_method': 'no'as discussed in #460.What testing has been done?
Tested with the 2nd commit from #460, with
'python_codegen_method': Noneadded to the override.