docs: add layer styleguide #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amstewart
requested review from
SparkingSpork,
shruthi-ravi,
ckoellin and
a team
bstreiff
reviewed
Aug 16, 2022
amstewart
force-pushed
the
dev/hardknott/styleguide
branch
from
5541431 to
fc8dc83
Compare
Patch V2
|
bstreiff
approved these changes
Aug 19, 2022
Add a first draft of a meta-nilrt layer styleguide, to coordinate syntax and styling. Signed-off-by: Alex Stewart <[email protected]>
Not all upstream projects have "mailing lists", and sections of the styleguide which reference linking to the upstream list might be confusing to developers. Make it clear that the upstream link can refer to a merge PR as well. Signed-off-by: Alex Stewart <[email protected]>
amstewart
force-pushed
the
dev/hardknott/styleguide
branch
from
fc8dc83 to
e0d7b17
Compare
Patch V3
|
amstewart
added a commit
to ni/nilrt
that referenced
this pull request
Aug 23, 2022
The styleguide information from the nilrt.git CONTRIBUTING document has been copied into the meta-nilrt.git:docs/styleguide.md doc, in meta-nilrt [#447](ni/meta-nilrt#447). Remove it from the CONTRIBUTING doc. Signed-off-by: Alex Stewart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a first draft of a meta-nilrt layer styleguide, to coordinate syntax
and styling.
Signed-off-by: Alex Stewart [email protected]
This styleguide includes some existing style sections from the nilrt.git CONTRIBUTING guide. I'll submit a PR to remove it from that document.