[High Priority] Update default value for the pin map sites #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jotheeswaran-Nandagopal
requested review from
csjall,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
Jotheeswaran-Nandagopal
changed the title
...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako
Show resolved
Hide resolved
|
Can you clarify what the problem was a bit more?
What is the scenario here? The steps to hit this and the result? |
bkeryan
approved these changes
Sep 23, 2024
MounikaBattu17
pushed a commit
that referenced
this pull request
Sep 23, 2024
fix: add default sites (cherry picked from commit 868b6db)
1 task
dixonjoel
added a commit
that referenced
this pull request
Sep 24, 2024
…the pin map sites (#921) [High Priority] Update default value for the pin map sites (#915) fix: add default sites (cherry picked from commit 868b6db) Co-authored-by: Jotheeswaran-Nandagopal <[email protected]> Co-authored-by: Joel Dixon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
PinMapContext.sites.Why should this Pull Request be merged?
Context: https://dev.azure.com/ni/DevCentral/_git/983dfe62-3b16-436f-b2ef-d98a72840b64/pullrequest/698395
What testing has been done?