[releases/1.2] service: Fix tag deserialization for large messages #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tests: Add test cases for big messages (100 fields) * service: Fix tag deserialization for large messages Tags are i32 varints, but we were only deserializing the first byte. Simplify some related details: - Decoding a varint returns the updated position, so we don't need to use encoder._TagSize() - We can directly construct a memory view once instead of constructing a BytesIO for each loop iteration. * tests: Use pytest.approx instead of choosing exactly comparable floats
bkeryan
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
mshafer-NI and
nstokes-nati
as code owners
|
Are we also going to add a 1.2.0.1 bug fix release? |
dixonjoel
approved these changes
Dec 13, 2023
Released Python packages have 3 version number fields to work with, so 1.2.1 would be the bug fix release. You can also do 1.2.0-post2 but that's typically for non-code changes such as packaging problems. We can build a 1.2.1-dev0 for testing beforehand, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Cherry-pick #552 into releases/1.2.
Description:
Why should this Pull Request be merged?
Fixes AB#2602618: Protobuf Error on Measurement run [MeasurementLink UI Editor/InstrumentStudio]
Release the fix in version 1.2.1.
What testing has been done?
Ran
poetry run pytest -vin both releases/1.2 and main branches.Manually tested the service attached to the bug report with my
users/bkeryan/fix-field-id-1.2branch (targetingreleases/1.2).