Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add integration and acceptance tests for NI-Digital and NI-Switch drivers session management APIs #503

Merged
merged 19 commits into from
Nov 8, 2023

Conversation

jayaseelan-james
Copy link
Contributor

What does this Pull Request accomplish?

Includes nidigitial_measurement.py and niswitch_measurement.py test service modules and adds integration and acceptance tests for nidigital and niswitch driver-specific session management APIs.

Why should this Pull Request be merged?

To add "nidigital" and "niswitch" driver-specific tests to the repository. #AB2570088

What testing has been done?

Ran mypy and pytest.

Copy link

github-actions bot commented Nov 6, 2023

Test Results

       30 files  ±    0         30 suites  ±0   40m 47s ⏱️ + 3m 22s
     504 tests +  13       504 ✔️ +  13         0 💤 ±0  0 ±0 
12 640 runs  +130  11 580 ✔️ +130  1 060 💤 ±0  0 ±0 

Results for commit 2e5b9b7. ± Comparison against base commit 01dff89.

♻️ This comment has been updated with latest results.

tests/utilities/nidigital_measurement/__init__.py Outdated Show resolved Hide resolved
tests/utilities/nidigital_measurement/__init__.py Outdated Show resolved Hide resolved
tests/utilities/nidigital_measurement/__init__.py Outdated Show resolved Hide resolved
tests/acceptance/test_nidigital_measurement.py Outdated Show resolved Hide resolved
tests/utilities/nidigital_measurement/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestion: group channels by session name instead of hacking around it.

tests/utilities/nidigital_measurement/__init__.py Outdated Show resolved Hide resolved
tests/utilities/nidigital_measurement/__init__.py Outdated Show resolved Hide resolved
@bkeryan bkeryan merged commit f8ea647 into main Nov 8, 2023
17 checks passed
@bkeryan bkeryan deleted the users/jay/tests-for-niswitch-and-nidigital branch November 8, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants