-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Add integration and acceptance tests for NI-Digital and NI-Switch drivers session management APIs #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: niswitch test measurement
refactor: niswitch integration tests fix: get niswitch connections test
tests: add integration tests for nidigital driver session APIs
jayaseelan-james
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
November 6, 2023 06:56
vigkre
approved these changes
Nov 6, 2023
dixonjoel
approved these changes
Nov 6, 2023
keer1111
approved these changes
Nov 6, 2023
bkeryan
requested changes
Nov 7, 2023
tests/assets/integration/session_management/PinLevels.digilevels
Outdated
Show resolved
Hide resolved
bkeryan
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestion: group channels by session name instead of hacking around it.
bkeryan
reviewed
Nov 7, 2023
tests/utilities/niswitch_measurement/NISwitchMeasurement.serviceconfig
Outdated
Show resolved
Hide resolved
bkeryan
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Includes
nidigitial_measurement.py
andniswitch_measurement.py
test service modules and adds integration and acceptance tests for nidigital and niswitch driver-specific session management APIs.Why should this Pull Request be merged?
To add "nidigital" and "niswitch" driver-specific tests to the repository. #AB2570088
What testing has been done?
Ran mypy and pytest.