service: Add driver-specific get_*_connection(s) APIs #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_with_typed_session() was incorrectly assuming that the runtime type matches the static type. Also, it was trying to infer the static type variable `TSession` based on the runtime type expression `type(session)`.
…and they don't match any connections
For strings, repr() doesn't just add single quotes. It also escapes special characters.
bkeryan
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
mshafer-NI and
nstokes-nati
as code owners
|
Looks good. I'll wait for the target to change to main before approving. |
dixonjoel
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add driver-specific APIs such as
get_nidcpower_connection(s).Why should this Pull Request be merged?
Part of the new session management API.
What testing has been done?
Ran new unit tests.