-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service: Update reserve_session(s) to accept a single pin and explicitly specify default timeout #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
mshafer-NI and
nstokes-nati
as code owners
September 20, 2023 23:14
Test Results 12 files ± 0 12 suites ±0 2m 21s ⏱️ +19s Results for commit d5b70fa. ± Comparison against base commit ceda75a. This pull request removes 3 and adds 20 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
dixonjoel
reviewed
Sep 21, 2023
dixonjoel
reviewed
Sep 21, 2023
dixonjoel
reviewed
Sep 21, 2023
dixonjoel
approved these changes
Sep 21, 2023
dixonjoel
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
SessionManagementClient
:reserve_session(s)
to accept a single pin for thepin_or_relay_names
argument.reserve_session(s)
andreserve_all_registered_sessions
to explicitly specify a default timeout of 0.0.RuntimeWarning
when you specify a negative timeout other than -1, such astimeout=-2
ortimeout=-1e6
. This maintains compatibility with the existing behavior, but encourages clients to use -1 for an infinite timeout.Why should this Pull Request be merged?
Accepting a single pin allows calling
reserve_session(context, "Vdd")
without wrapping the pin name in a list or tuple.In Python,
str
is aIterable[str]
that iterates over the characters of the string. Before this change,reserve_session(context, "Vdd")
would pass type checking, but at run time it translated"Vdd"
to["V", "d", "d"]
, which is surprising behavior.The default timeout behavior was previously undocumented. Using a default value of
None
was ambiguous, becauseNone
could plausibly be interpreted as either -1 (infinite) or 0.0 (non-blocking).What testing has been done?
Ran
poetry run pytest -v
.Manually tested a modified version of
nidmm_measurement
.Ran
poetry run sphinx-build _docs_source docs -b html -W --keep-going
and looked at the output.