Disable explicit member accessibility for constructors #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jattasNI
requested review from
mure,
rajsite and
TrevorKarjanis
as code owners
rajsite
approved these changes
Sep 20, 2024
TrevorKarjanis
approved these changes
Sep 25, 2024
|
@mure since you filed the original issue and the changes in this PR are trivial, I'm gonna assume you're ok with it and complete the PR today. |
mure
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Resolves #100. Constructors may now be marked
public,private, or have no accessibility modifier. Previously they had to be markedpublicorprivate.Implementation
Set
overrides: { constructors: 'off' }in the TS rule configuration.Testing
Added a constructor to the TypeScript test and verified the rule previously errored if it didn't have a modifier but now allows this.