Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DAQmx proto file with misplaced attributes #934

Merged
merged 15 commits into from
Jun 2, 2023
Merged

Fix DAQmx proto file with misplaced attributes #934

merged 15 commits into from
Jun 2, 2023

Conversation

Sakthi-SM
Copy link
Contributor

What does this Pull Request accomplish?

In NI-DAQmx, the attributes with bitfield enums are placed under the wrong type during the proto file generation. This PR fixes this and places these attributes under the right type.

Why should this Pull Request be merged?

This fixes Bug 2395661: Attributes with bitfield enum are listed under the wrong type in DAQmx proto file

What testing has been done?

The changes have been tested manually

Sakthi Subramanian Muthuramalingam and others added 2 commits May 23, 2023 16:13
@Sakthi-SM Sakthi-SM requested review from bkeryan and keer1111 May 23, 2023 15:57
zhindes
zhindes approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@zhindes zhindes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is simply pulling in some fixes to scrapigen? Do you mind linking that in your PR description?

bkeryan
bkeryan requested changes May 24, 2023
View reviewed changes
generated/nidaqmx/nidaqmx.proto Show resolved Hide resolved
source/codegen/common_helpers.py Outdated Show resolved Hide resolved
source/codegen/common_helpers.py Outdated Show resolved Hide resolved
generated/nidaqmx/nidaqmx.proto Show resolved Hide resolved
bkeryan
bkeryan requested changes May 24, 2023
View reviewed changes
source/codegen/metadata/nidaqmx/__init__.py Outdated Show resolved Hide resolved
source/codegen/metadata/nidaqmx/attributes_addon.py Outdated Show resolved Hide resolved
@Sakthi-SM Sakthi-SM marked this pull request as ready for review May 29, 2023 13:07
@Sakthi-SM Sakthi-SM requested a review from bkeryan May 29, 2023 13:07
bkeryan
bkeryan requested changes May 30, 2023
View reviewed changes
source/codegen/templates/proto.mako Outdated Show resolved Hide resolved
generated/nidaqmx/nidaqmx.proto Outdated Show resolved Hide resolved
Sakthi Subramanian Muthuramalingam added 2 commits May 31, 2023 16:04
@Sakthi-SM Sakthi-SM requested a review from bkeryan May 31, 2023 14:20
@bkeryan bkeryan added the binary-breaking Change to proto file that requires client updates label May 31, 2023
@Sakthi-SM Sakthi-SM mentioned this pull request Jun 1, 2023
Merged
@keer1111 keer1111 merged commit 45d9e16 into main Jun 2, 2023
@keer1111 keer1111 deleted the users/sakthi/fix-move-bitfield-enum-attributes branch June 2, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhindes zhindes zhindes approved these changes

@reckenro reckenro reckenro approved these changes

@astarche astarche astarche approved these changes

@bkeryan bkeryan bkeryan approved these changes

@keer1111 keer1111 Awaiting requested review from keer1111

Assignees
No one assigned
Labels
binary-breaking Change to proto file that requires client updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Sakthi-SM @bkeryan @zhindes @astarche @reckenro @keer1111 @samchris007 @keerthee3