Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMakeLists.txt #893

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Update CMakeLists.txt #893

merged 1 commit into from
Mar 29, 2023

Conversation

christag-ni
Copy link
Contributor

What does this Pull Request accomplish?

Bumps the version in CMake file

Why should this Pull Request be merged?

To accurately reflect the version grpc-device is in

What testing has been done?

No testing

Copy link
Collaborator

@reckenro reckenro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine.

I thought about this more after we discussed it and I don't think we should submit anything into main until we've bumped the exports from main to be 2.2 (in AzDo). This is mainly so if someone gets the latest 2.1 exports they'll get the finals from the release branch.

@christag-ni
Copy link
Contributor Author

Change looks fine.

I thought about this more after we discussed it and I don't think we should submit anything into main until we've bumped the exports from main to be 2.2 (in AzDo). This is mainly so if someone gets the latest 2.1 exports they'll get the finals from the release branch.

Should I then create a PR for the ni-central changes, and once those changes are submitted, we submit this change in grpc-device?

@reckenro
Copy link
Collaborator

Should I then create a PR for the ni-central changes, and once those changes are submitted, we submit this change in grpc-device?

Yes, sorry for switching these around. But yes, I think we're good to make that AzDo change now that Wes's cherry-pick went in and we're firm that we're not going to make further changes to the releases/2.1 branch.

@reckenro reckenro self-requested a review March 29, 2023 15:41
@christag-ni christag-ni merged commit f26827b into main Mar 29, 2023
@christag-ni christag-ni deleted the christag-ni-versionBump branch March 29, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants