RFmx VNA and SpecAn 24C4 API changes #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahulBenaka
requested review from
reckenro,
astarche and
maxxboehme
as code owners
ThangamV-NI
approved these changes
Dec 12, 2024
reckenro
added
the
source-breaking
reckenro
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Updates niRFmxSpecAn in grpc-device-scrapigen to 25.0.0
Updates niRFmxVNA in grpc-device-scrapigen to 25.0.0
Updates the gRPC Scrapigen Device Code for SPecAn AMPM properties
Updates the gRPC Scrapigen Device Code for VNA LoadDataToMeasurementMemoryFromFile API parameter's name change from memoryDataName to measurementMemoryDataName
Why should this Pull Request be merged?
Updated to match the upcoming release of niRFmxSpecAn 25.0.0
Updated to match the upcoming release of niRFmxVNA 25.0.0
What testing has been done?
Manually inspected generated files.
Copied files from grpc-device-scrapigen/out/rfmxvna/export/ to grpc-device/source/codegen/metadata/nirfmxvna/ and built grpc-device successfully.
Manually inspected nirfmxvna.proto file.
Copied files from grpc-device-scrapigen/out/rfmxspecan/export/ to grpc-device/source/codegen/metadata/nirfmxspecan/ and built grpc-device successfully.
Manually inspected nirfmxspecan.proto file.