Auto-generation support for daqmx streaming apis #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amehra-ni
reviewed
Nov 20, 2024
doshirohan
reviewed
Nov 21, 2024
Raghav-NI
changed the title
Raghav-NI
requested review from
reckenro,
astarche and
maxxboehme
as code owners
astarche
reviewed
Nov 21, 2024
astarche
reviewed
Nov 21, 2024
astarche
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR adds support for auto-generation of DAQmx streaming APIs.
Why should this Pull Request be merged?
custom_proto.makowhich defines protobuf message definitions to encapsulate different data types for DAQmx apis.service_helpers.makoto auto-generate the streaming function bodies.service_helpers.pyandcommon_helpers.pyto generate the correct function structure for streaming apis.nifpga_service.cpp.What testing has been done?
I am able to build the server code without any errors and able to use the client call and call the server with all the new streaming APIs.