Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FPGA interrupt APIs #1083

Merged
merged 1 commit into from
Aug 27, 2024
Merged

FPGA interrupt APIs #1083

merged 1 commit into from
Aug 27, 2024

Conversation

amehra-ni
Copy link
Contributor

@amehra-ni amehra-ni commented Aug 26, 2024 •
edited
Loading

What does this Pull Request accomplish?

This PR contains code generation for Interrupt FPGA functions.

Why should this Pull Request be merged?

  • Updated metadata.
  • Updated the custom service file by removing unnecessary code.

What testing has been done?

  • No compile or codegen issues.
  • Manually verified server handlers for all APIs and compared them with documentation for the APIs mentioned.
  • Manually tested these two APIs with client code which calls the functions and data comes as expected.

@amehra-ni amehra-ni self-assigned this Aug 26, 2024
@amehra-ni amehra-ni requested review from doshirohan and asumit August 26, 2024 11:19
@amehra-ni amehra-ni marked this pull request as ready for review August 26, 2024 11:21
doshirohan
doshirohan approved these changes Aug 26, 2024
View reviewed changes
generated/nifpga/nifpga_library.cpp Show resolved Hide resolved
generated/nifpga/nifpga_service.cpp Show resolved Hide resolved
@amehra-ni amehra-ni merged commit 3705f87 into main Aug 27, 2024
10 of 11 checks passed
@amehra-ni amehra-ni deleted the users/amehra/support-irq-apis branch August 27, 2024 14:33
@amehra-ni amehra-ni mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reckenro reckenro reckenro approved these changes

@astarche astarche astarche approved these changes

@doshirohan doshirohan doshirohan approved these changes

@asumit asumit Awaiting requested review from asumit

@maxxboehme maxxboehme Awaiting requested review from maxxboehme maxxboehme is a code owner

Assignees

@amehra-ni amehra-ni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amehra-ni @doshirohan @astarche @reckenro