Grpc - LoadReferenceWaveformFromTDMSFile #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Work Item #2573723 -> https://dev.azure.com/ni/DevCentral/_workitems/edit/2573723/ |
ChiragKavdia
changed the title
ChiragKavdia
requested review from
reckenro,
astarche and
maxxboehme
as code owners
ChiragKavdia
changed the title
astarche
approved these changes
Dec 8, 2023
reckenro
approved these changes
Dec 8, 2023
maxxboehme
approved these changes
Dec 11, 2023
maxxboehme
deleted the
users/ckavdia/GRPC-AMPMLoadReferenceWaveformFromTDMSFile
branch
|
@maxxboehme RFmx is getting this dependency ni-grpc-device-restricted-files from the following location I don't see any latest build. How does it get generated? We are dependent on this new export to push some changes in ni-central RFmx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Added Grpc device support for newly added private API - LoadReferenceWaveformFromTDMSFile
It has been implemented for 2 personalities for RFmx
Why should this Pull Request be merged?
To support new APIs
What testing has been done?
Manually inspected generated files.
Manually inspected nirfmxspecan.proto & nirfmxwlan.proto file.