fix sideband race condition by passing std::string instead of char* t…

…o thread proc (#1131)
ni · Nov 27, 2024 · 06ed455 · 06ed455
1 parent dea3b5a
commit 06ed455
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/source/server/data_moniker_service.cpp b/source/server/data_moniker_service.cpp
@@ -168,6 +168,7 @@ Status DataMonikerService::BeginSidebandStream(ServerContext* context, const Beg
 
   char identifier[32] = {};
   InitOwnerSidebandData(strategy, bufferSize, identifier);
+  std::string identifierString(identifier);
 
   response->set_strategy(request->strategy());
   response->set_sideband_identifier(identifier);
@@ -179,7 +180,7 @@ Status DataMonikerService::BeginSidebandStream(ServerContext* context, const Beg
   auto readers = new EndpointList();
   InitiateMonikerList(request->monikers(), readers, writers);
 
-  auto thread = new std::thread(RunSidebandReadWriteLoop, identifier, strategy, readers, writers);
+  auto thread = new std::thread(RunSidebandReadWriteLoop, identifierString, strategy, readers, writers);
   thread->detach();
 
   return Status::OK;