Conv2d Per EG Gradient Weights #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve effiency of extra_output propogation Fix batchnorm inference
More conv2d_nchw_grad_weight Fix conv2d_grad_weight Ignore pylint warning
Hack output and extra_output propogation to work
nhynes
reviewed
Oct 20, 2018
There was a problem hiding this comment.
Looks great! Can you add a quick test in Python for this? You can follow https://github.com/nhynes/tvm/blob/master/nnvm/tests/python/compiler/test_top_level2.py#L12 as a template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My implementation of conv2d per-example gradients function