Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove basic templates from website #137

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

frankieroberto
Copy link
Contributor

Removes all templates from the documentation website except the ones which mock up the NHS website pages.

These templates are included in the kit itself, so it’s better to get people to browse and copy and paste them from there.

The NHS website page templates are kept, as the plan is to remove these from the kit itself and keep them on the documentation website for now (but possibly move them into a separate package/plugin in future).

Step 1. of sorting out the templates - see #60.

Screenshots

Before After
templates-before templates-after

Remove the basic templates from the documentation website.

These templates are included in the kit itself, so it’s better to get people to browse and copy and paste them from there.
@frankieroberto frankieroberto self-assigned this Nov 19, 2024
@frankieroberto frankieroberto temporarily deployed to nhs-prototyp-remove-ini-psjtz5 November 19, 2024 22:02 Inactive
Copy link
Contributor

@vickytnz vickytnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Not blocking as can be done after - I think that this can be moved into the guides section or at least linked to it from the breadcrumbs and as a link from the guides page.

@anandamaryon1
Copy link
Contributor

Should this page also mention the Design System 'Pages' patterns? https://service-manual.nhs.uk/design-system/patterns

This is where I think the page templates should all end up in future, but it already has a few, including the start page which is useful.

@vickytnz vickytnz added the Content Improvements or additions to documentation label Nov 24, 2024
@frankieroberto
Copy link
Contributor Author

Should this page also mention the Design System 'Pages' patterns? https://service-manual.nhs.uk/design-system/patterns

This is where I think the page templates should all end up in future, but it already has a few, including the start page which is useful.

Good call! Added in 75bdaf1.

@frankieroberto frankieroberto merged commit 20d6da4 into main Nov 25, 2024
4 checks passed
@frankieroberto frankieroberto deleted the remove-initial-batch-of-templates branch November 25, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

3 participants